Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom DNS resolvers for Let's Encrypt. #4101

Merged
merged 3 commits into from Oct 25, 2018
Merged

Support custom DNS resolvers for Let's Encrypt. #4101

merged 3 commits into from Oct 25, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Oct 24, 2018

What does this PR do?

  • Support custom DNS resolvers for LE.
  • allow to remove precheck

Motivation

Fixes #3585
Related to #4088

More

  • Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 1.7 milestone Oct 24, 2018
@ldez ldez changed the title Support custom DNS resolvers for LE. Support custom DNS resolvers for Let's Encrypt. Oct 24, 2018
mmatur
mmatur approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit 74dc5b1 into traefik:v1.7 Oct 25, 2018
@traefiker traefiker mentioned this pull request Oct 25, 2018
Closed
@ldez ldez deleted the fix/acme-resolvers branch October 25, 2018 21:14
@ldez ldez mentioned this pull request Jan 9, 2019
Merged
1 task
@rcmcdonald91 rcmcdonald91 mentioned this pull request Jul 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/M
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mmatur @dtomcej @traefiker