Add provider specific cnameFlattening Trigger #4134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/configuration/backends/consulcatalog.md # docs/configuration/backends/docker.md # docs/configuration/backends/ecs.md # docs/configuration/backends/marathon.md # docs/configuration/backends/mesos.md # docs/configuration/backends/rancher.md # provider/consulcatalog/config_test.go # provider/docker/config.go # provider/docker/config_container_docker_test.go # provider/ecs/config.go # provider/ecs/config_test.go # provider/kubernetes/kubernetes.go # provider/kv/keynames.go # provider/kv/kv_config.go # provider/label/names.go # provider/marathon/config_test.go # provider/mesos/config_test.go # provider/rancher/config.go # provider/rancher/config_test.go # types/types.go
geraldcroes
added
status/1-needs-design-review
and removed
status/0-needs-triage
labels
|
Hi @gamalan! Thank you for your contribution to the project, we're very grateful ... but at the same time we're embarrassed because we're not ready to merge your work. As we said in the latests release note , we're re-thinking some core aspects of Traefik. As a consequence, the code base has drastically changed (you can see for yourself the #4168 PR ... quite a refactoring). Even though we cannot accept the PR right now, we would like to keep it in our radar. I propose we close the current PR but keep #4032 open to ping you when the time comes. WDYT? |
|
@geraldcroes ah, I see. Okay then, I probably check other issues to solve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add provider specific cnameFlattening Trigger.
Motivation
To enable cnameFlattening only for a specific provider. But keep global if needed. Theoretically, it should only be enabled for a specific service.
This addressing PR #3403, by default when cnameFlattening is enabled, it will check for all route. After some thinking again, although the record is being cached, it should not necessarily check all service.
More
Additional Notes
If approved, then traefik-extra-service-fabric need to be updated as well.
Re add from PR #3843