Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query params in health check #4188

Merged
merged 1 commit into from Nov 15, 2018
Merged

Query params in health check #4188

merged 1 commit into from Nov 15, 2018

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Nov 12, 2018

What does this PR do?

This PR allows user to set query param in health check

Motivation

Fixes #4182

More

  • Added/updated tests

@mmatur mmatur added this to the 1.7 milestone Nov 12, 2018
@mmatur mmatur self-assigned this Nov 12, 2018
@ldez ldez changed the title Fix query param in health check Query param in health check Nov 12, 2018
@ldez ldez changed the title Query param in health check Query params in health check Nov 12, 2018
ldez
ldez approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez unassigned mmatur Nov 13, 2018
jbdoumenjou
jbdoumenjou approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit f25ebc7 into traefik:v1.7 Nov 15, 2018
@traefiker traefiker mentioned this pull request Nov 15, 2018
Closed
@ldez ldez mentioned this pull request Nov 19, 2018
Merged
17 tasks
@ldez ldez mentioned this pull request Dec 5, 2018
Merged
5 tasks
@mmatur mmatur deleted the fix/query-param-healthcheck branch January 10, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/healthcheck kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmatur @juliens @jbdoumenjou @ldez @traefiker