Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ParseInt instead of Atoi for parsing durations #4263

Merged
merged 1 commit into from Dec 3, 2018

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Dec 3, 2018

What does this PR do?

This PR upgrades flaeg dependency to avoid error when deserializing durations with values >= to 2^32 on 32 bits architectures.

Additional Notes

containous/flaeg#52

@mmatur mmatur added status/2-needs-review kind/bug/fix a bug fix bot/light-review decreases the number of required LGTM from 3 to 1. labels Dec 3, 2018
@mmatur mmatur added this to the 1.7 milestone Dec 3, 2018
@mmatur mmatur self-assigned this Dec 3, 2018
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 6aa040a into traefik:v1.7 Dec 3, 2018
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Dec 3, 2018
@mmatur mmatur deleted the fix/upgrade-flaeg branch December 3, 2018 09:34
@mmatur mmatur changed the title Fix upgrade flaeg Use ParseInt instead of Atoi for parsing durations Dec 3, 2018
@ldez ldez mentioned this pull request Dec 4, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants