Fix label segmentation when using custom prefix #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
status/2-needs-review
kind/bug/fix
|
Thx peeps!
…On Fri, Dec 7, 2018, 16:38 Traefiker Bot ***@***.*** wrote:
Merged #4272 <#4272> into v1.7.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4272 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABFW9SvPTskJoD7OaV468NLL9nPTIeERks5u2ot1gaJpZM4ZEBPd>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes a bug with the consul catalog label segmentation when using a custom prefix (other than
traefik). I found this on our QA system when implementing a second traefik cluster for internal traffic.Motivation
I never realised that Provider.label is actually being reset to the standard one: https://github.com/containous/traefik/blob/v1.7/provider/consulcatalog/convert_types.go#L22
More
Additional Notes