Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude websocket connections from Average Response Time #4313

Merged
merged 2 commits into from Mar 27, 2019
Merged

Exclude websocket connections from Average Response Time #4313

merged 2 commits into from Mar 27, 2019

Conversation

siyu6974
Copy link
Contributor

What does this PR do?

Update dependency to fix #3620

Motivation

The average response time on my dashboard was really bad because of it counting websocket connect.

More

not relevant
- [ ] Added/updated tests
- [ ] Added/updated documentation

Additional Notes

@ldez

This comment has been minimized.

@siyu6974

This comment has been minimized.

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should wait for thoas/stats#30

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez unassigned juliens and ldez Mar 27, 2019
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbdoumenjou jbdoumenjou mentioned this pull request Mar 29, 2019
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants