Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Letsencrypt - Add info on httpreq format #4355

Merged
merged 2 commits into from Jan 4, 2019
Merged

Letsencrypt - Add info on httpreq format #4355

merged 2 commits into from Jan 4, 2019

Conversation

goetas
Copy link
Contributor

@goetas goetas commented Jan 4, 2019

What does this PR do?

Add info on HTTP request format when using httpreq DNS challenge

Motivation

Currently is not explained what is sent in the HTTP request

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez self-requested a review January 4, 2019 10:34
@goetas goetas requested review from a team as code owners January 4, 2019 10:53
@ldez ldez changed the base branch from master to v1.7 January 4, 2019 10:53
@ldez ldez removed request for a team January 4, 2019 10:53
@mmatur mmatur added this to the 1.7 milestone Jan 4, 2019
mmatur
mmatur approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 94de6eb into traefik:v1.7 Jan 4, 2019
@ldez ldez mentioned this pull request Jan 8, 2019
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/acme area/documentation size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@goetas @juliens @mmatur @ldez @traefiker