Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrates the pass client tls cert middleware #4373

Merged
merged 1 commit into from Jan 9, 2019
Merged

Migrates the pass client tls cert middleware #4373

merged 1 commit into from Jan 9, 2019

Conversation

jbdoumenjou
Copy link
Member

What does this PR do?

  • Migrates the last pass tls client cert middleware from V1.7
  • Fix a misspelling on info

Motivation

  • Be up to date with the pass tls cert middleware

More

  • Added/updated tests
  • Added/updated documentation

@jbdoumenjou jbdoumenjou added this to the next milestone Jan 9, 2019
@ldez ldez added the kind/enhancement a new or improved feature. label Jan 9, 2019
geraldcroes
geraldcroes approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 7efafa5 into traefik:master Jan 9, 2019
@jbdoumenjou jbdoumenjou deleted the refactor/passtlscert branch January 9, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@geraldcroes geraldcroes geraldcroes approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/middleware kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jbdoumenjou @juliens @geraldcroes @ldez @traefiker