Route priorities: document minimum priority value #4374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geraldcroes
added
area/documentation
status/2-needs-review
and removed
status/0-needs-triage
labels
traefiker
added
bot/merge-retry-1
status/4-merge-in-progress
and removed
bot/merge-retry-1
labels
I had the case that i needed a rule to be matched after all other rules and it was not until i started reading the source code (https://github.com/containous/traefik/blob/master/server/router/rules.go#L20) that i realized a value of zero will not place the route to the end of the list. It would have saved me some time, had the documentation already contained this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
document minimum priority value
Motivation
I had the case that i needed a rule to be matched after all other rules and it was not until i started reading the source code (https://github.com/containous/traefik/blob/master/server/router/rules.go#L20) that i realized a value of zero will not place the route to the end of the list.
It would have saved me some time, had the documentation already contained this line.
More