Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(constraint): Supports kv backends #439

Closed

Conversation

samber
Copy link
Contributor

@samber samber commented Jun 7, 2016

Related to #311

  • BoltDB
  • Consul KV
  • Zookeeper
  • Etcd

@samber samber mentioned this pull request Jun 7, 2016
7 tasks
@keis
Copy link

keis commented Jun 7, 2016

In this one the check is triggered from the template and while not inheritly bad I think that for the sake of consistency the filter should happen before the template like in the others.

@emilevauge
Copy link
Member

@samber thanks a lot :)
I tend to agree with @keis on the filtering :)

@emilevauge emilevauge added this to the 1.0 milestone Jun 7, 2016
@samber samber force-pushed the TRAEFIK-311--supports-kv-stores-backends branch from 6ea5714 to 0ca64b6 Compare June 20, 2016 23:03
@samber samber force-pushed the TRAEFIK-311--supports-kv-stores-backends branch from 0ca64b6 to 1d127eb Compare June 20, 2016 23:04
@samber samber force-pushed the TRAEFIK-311--supports-kv-stores-backends branch from 1d127eb to 3390074 Compare June 20, 2016 23:42
@samber
Copy link
Contributor Author

samber commented Jun 21, 2016

Corrected ;-)

@vdemeester
Copy link
Contributor

LGTM 🐋

@emilevauge
Copy link
Member

@samber, thanks a lot :)

Other than that, looks great :)

@emilevauge
Copy link
Member

Hi @samber, I'm planning to get this PR in the 1.1 releases. Do you think it's possible ?

@emilevauge emilevauge mentioned this pull request Sep 20, 2016
@emilevauge
Copy link
Member

PR carried in #689 because of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants