-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(constraint): Supports kv backends #439
Closed
samber
wants to merge
2
commits into
traefik:master
from
samber:TRAEFIK-311--supports-kv-stores-backends
Closed
feat(constraint): Supports kv backends #439
samber
wants to merge
2
commits into
traefik:master
from
samber:TRAEFIK-311--supports-kv-stores-backends
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
In this one the check is triggered from the template and while not inheritly bad I think that for the sake of consistency the filter should happen before the template like in the others. |
samber
force-pushed
the
TRAEFIK-311--supports-kv-stores-backends
branch
from
June 20, 2016 23:03
6ea5714
to
0ca64b6
Compare
samber
force-pushed
the
TRAEFIK-311--supports-kv-stores-backends
branch
from
June 20, 2016 23:04
0ca64b6
to
1d127eb
Compare
samber
force-pushed
the
TRAEFIK-311--supports-kv-stores-backends
branch
from
June 20, 2016 23:42
1d127eb
to
3390074
Compare
Corrected ;-) |
LGTM 🐋 |
@samber, thanks a lot :)
Other than that, looks great :) |
Hi @samber, I'm planning to get this PR in the 1.1 releases. Do you think it's possible ? |
Merged
PR carried in #689 because of inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #311