Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount acme folder instead of file #441

Merged
merged 1 commit into from Jun 23, 2016
Merged

Conversation

NicolasGeraud
Copy link
Contributor

@NicolasGeraud NicolasGeraud commented Jun 8, 2016

If you use traefik in Docker and use Let's Encrypt, you have to mount the folder containing the acme.json file instead of the file itself.

# WARNING, if you use Traefik in Docker, don't forget to mount this file as a volume.
# WARNING, if you use Traefik in Docker, don't forget to mount the folder containing this file as a volume.
# storageFile = "/etc/traefik/acme/acme.json"
# $ docker run -v "/my/host/acme:/etc/traefik/acme" traefik
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you mount the acme.json ? ;-)

docker run -v "/my/host/acme.json:/etc/traefik/acme.json" traefik

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because when I've mounted the file, it created a folder named acme.json on my host.

If it's not an expected behavior, I can test on a fresh environment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, it will work if you create an empty acme.json before starting the container.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I think this must be specified in the documentation.
Do you prefer to specify that the acme.json file must exists on the host, or to mount a folder instead of a file ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the documentation I think we should specify both 😇. Then the user has the choice of which one to use 😝.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will update my PR

@vdemeester
Copy link
Contributor

ping @NicolasGeraud

@NicolasGeraud NicolasGeraud force-pushed the patch-1 branch 2 times, most recently from 98e9dcf to 92a6a35 Compare June 20, 2016 11:49
@samber
Copy link
Contributor

samber commented Jun 20, 2016

LGTM

@emilevauge
Copy link
Member

emilevauge commented Jun 22, 2016

Sorry @NicolasGeraud, needs a rebase...
I'll merge it as soon as rebased.

I you use traefik in Docker and use Let's Encrypt, you have to mount the folder containing the acme.json file instead of the file itself.
@vdemeester vdemeester merged commit 8e561d9 into traefik:master Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants