Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Marathon support. #4415

Merged
merged 5 commits into from Jan 29, 2019
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Jan 22, 2019

What does this PR do?

Adds Marathon support.

Motivation

To have the Marathon provider.

More

  • Added/updated tests
  • [ ] Added/updated documentation

Additional Notes

Co-authored-by: Julien Salleyron julien@containo.us

@ldez ldez added this to the next milestone Jan 22, 2019
@ldez ldez requested a review from a team as a code owner January 22, 2019 01:20
@dtomcej
Copy link
Contributor

dtomcej commented Jan 22, 2019

Motivation
To have the Docker provider.

😆

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

provider/marathon/config.go Outdated Show resolved Hide resolved
provider/marathon/config_test.go Outdated Show resolved Hide resolved
provider/marathon/config_test.go Outdated Show resolved Hide resolved
provider/marathon/config_test.go Outdated Show resolved Hide resolved
provider/marathon/config_test.go Outdated Show resolved Hide resolved
provider/marathon/config_test.go Outdated Show resolved Hide resolved
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez and others added 5 commits January 29, 2019 16:44
Co-authored-by: Julien Salleyron <julien@containo.us>
Co-Authored-By: ldez <ldez@users.noreply.github.com>
@traefiker traefiker merged commit 246b245 into traefik:master Jan 29, 2019
@ldez ldez deleted the feature/provider-marathon branch January 29, 2019 16:54
@kopax

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants