Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule syntax #4437

Merged
merged 5 commits into from Jan 30, 2019
Merged

New rule syntax #4437

merged 5 commits into from Jan 30, 2019

Conversation

juliens
Copy link
Member

@juliens juliens commented Jan 29, 2019 •
edited by ldez

What does this PR do?

Introduce a new syntax for the rules.

Motivation

More fun with rules 馃榾
Now you can use && || and ().
ex:

(Host(`myhost`) && Path(`/mypath`)) || Host(`otherhost`)

More

  • Added/updated tests

Additional Notes

Co-authored-by: jbdoumenjou jb.doumenjou@gmail.com

@juliens juliens added this to the next milestone Jan 29, 2019
@juliens juliens requested review from a team as code owners January 29, 2019 20:47
@ldez ldez requested review from ldez and removed request for a team January 29, 2019 22:44
ldez
ldez requested changes Jan 30, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憖

rules/parser.go Outdated Show resolved Hide resolved
rules/rules.go Outdated Show resolved Hide resolved
rules/rules.go Outdated Show resolved Hide resolved
rules/rules_test.go Outdated Show resolved Hide resolved
server/router/router.go Outdated Show resolved Hide resolved
ldez
ldez requested changes Jan 30, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憖

rules/rules.go Outdated Show resolved Hide resolved
rules/rules.go Outdated Show resolved Hide resolved
mmatur
mmatur requested changes Jan 30, 2019
View reviewed changes
rules/rules.go Outdated Show resolved Hide resolved
rules/rules_test.go Outdated Show resolved Hide resolved
server/router/router.go Outdated Show resolved Hide resolved
ldez
ldez approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens and others added 5 commits January 30, 2019 15:14
@juliens @jbdoumenjou @traefiker
New rule syntax
c46fc0e 
Co-authored-by: jbdoumenjou <jb.doumenjou@gmail.com>
@juliens @traefiker
fix tests.
7d11b13
@juliens @traefiker
fix review.
2aab772
@ldez @juliens @traefiker
Apply suggestions from code review
d24f612 
Co-Authored-By: juliens <julien.salleyron@gmail.com>
@ldez @traefiker
review: minor changes.
0717fb3
@traefiker traefiker merged commit 9ebe3c3 into traefik:master Jan 30, 2019
@juliens juliens deleted the poc-rules branch September 6, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/rules kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@juliens @jbdoumenjou @mmatur @ldez @traefiker