Instana tracer implementation #4453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevtainer
force-pushed
the
2876-add-instana-tracer
branch
from
3612181
to
d03bdf6
Compare
This comment has been minimized.
This comment has been minimized.
kevtainer
force-pushed
the
2876-add-instana-tracer
branch
from
d03bdf6
to
999a2da
Compare
This comment has been minimized.
This comment has been minimized.
ldez
added
area/middleware/tracing
and removed
bot/no-merge
contributor/waiting-for-corrections
labels
mmatur
requested changes
Feb 8, 2019
kevtainer
force-pushed
the
2876-add-instana-tracer
branch
from
c926752
to
fae7523
Compare
2 tasks
review: imports and logs. fix config doc
traefiker
force-pushed
the
2876-add-instana-tracer
branch
from
fae7523
to
934234d
Compare
|
How do you use this? I tried the config given as an example in the docs in this PR (btw, why does none of that show up in the actual docs?), but I get the following in logs: |
|
@remotezygote This PR was merged into master, not 1.7. It appears in the 2.0 release. For assistance with configuration, reach out on our slack: https://slack.traefik.io! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change adds the Instana tracer as an opentracing compatible backend
Motivation
I use both traefik and Instana, and this seemed like a worthwhile change to upstream
Fixes #2876
More
Additional Notes
Traefik is awesome