Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default value of buckets for Prometheus #4468

Merged
merged 1 commit into from Feb 5, 2019

Conversation

adam-golab
Copy link

What does this PR do?

Updated default value if buckets for Prometheus metrics. It should be homogeneous so the last value had a missing decimal place.

Motivation

I've got an error: Array contains values of type 'Float' and 'Integer', but arrays must be homogeneous after coping default value from the documentation.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@ldez ldez changed the base branch from master to v1.7 February 5, 2019 15:33
@ldez ldez force-pushed the prometheus-default-buckets branch from aee0e2b to fb2e03c Compare February 5, 2019 15:33
@adam-golab adam-golab requested review from a team as code owners February 5, 2019 15:33
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez removed request for a team February 5, 2019 15:33
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur added this to the 1.7 milestone Feb 5, 2019
@traefiker traefiker merged commit 67704e3 into traefik:v1.7 Feb 5, 2019
@ldez ldez changed the title Update default value in docs of buckets for Prometheus Update default value of buckets for Prometheus Feb 11, 2019
@ldez ldez mentioned this pull request Feb 13, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants