Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Kubernetes provider support #4476

Merged
merged 14 commits into from Feb 21, 2019
Merged

Adds Kubernetes provider support #4476

merged 14 commits into from Feb 21, 2019

Conversation

jbdoumenjou
Copy link
Member

What does this PR do?

Adds the kubernetes provider support.

Motivation

To have kubernetes provider.

More

  • Added/updated tests
  • Added/updated documentation

Co-authored-by: Julien Salleyron julien@containo.us

@jbdoumenjou jbdoumenjou requested a review from a team as a code owner February 7, 2019 13:56
@jbdoumenjou jbdoumenjou added this to the next milestone Feb 7, 2019
dtomcej
dtomcej suggested changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work so far! I love the ingress.Backend code simplification.

Some suggestions/review comments for my first read-over

provider/kubernetes/client.go Show resolved Hide resolved
provider/kubernetes/kubernetes.go Show resolved Hide resolved
provider/kubernetes/kubernetes.go Show resolved Hide resolved
provider/kubernetes/kubernetes.go Show resolved Hide resolved
provider/kubernetes/client.go Show resolved Hide resolved
mmatur
mmatur requested changes Feb 8, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job guys ;)

provider/kubernetes/kubernetes_test.go Outdated Show resolved Hide resolved
provider/kubernetes/namespace.go Outdated Show resolved Hide resolved
provider/kubernetes/namespace.go Outdated Show resolved Hide resolved
provider/kubernetes/namespace.go Outdated Show resolved Hide resolved
provider/kubernetes/namespace.go Outdated Show resolved Hide resolved
provider/kubernetes/namespace.go Outdated Show resolved Hide resolved
provider/kubernetes/kubernetes.go Outdated Show resolved Hide resolved
provider/kubernetes/kubernetes.go Outdated Show resolved Hide resolved
provider/kubernetes/client_test.go Outdated Show resolved Hide resolved
provider/kubernetes/client.go Outdated Show resolved Hide resolved
mmatur
mmatur approved these changes Feb 19, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed my feedback in person.
Will be addressed in a future PR.

LGTM
:shipit:

ldez
ldez requested changes Feb 20, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

provider/kubernetes/kubernetes.go Outdated Show resolved Hide resolved
provider/kubernetes/kubernetes.go Outdated Show resolved Hide resolved
provider/kubernetes/kubernetes.go Outdated Show resolved Hide resolved
provider/kubernetes/kubernetes_test.go Outdated Show resolved Hide resolved
provider/kubernetes/kubernetes_test.go Outdated Show resolved Hide resolved
@ldez ldez self-requested a review February 21, 2019 21:33
ldez
ldez approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou and others added 6 commits February 21, 2019 21:56
@jbdoumenjou @juliens @traefiker
Adds Kubernetes support.
f953fcd 
Co-authored-by: Julien Salleyron <julien@containo.us>
@ldez @traefiker
review: fix import
ab80c62
@ldez @traefiker
review: fix priorities.
a71eb37
@mmatur @jbdoumenjou @traefiker
Update provider/kubernetes/namespace.go
13c7927 
Co-Authored-By: jbdoumenjou <jb.doumenjou@gmail.com>
@mmatur @jbdoumenjou @traefiker
Update provider/kubernetes/namespace.go
a384334 
Co-Authored-By: jbdoumenjou <jb.doumenjou@gmail.com>
@mmatur @jbdoumenjou @traefiker
Update provider/kubernetes/namespace.go
add32a2 
Co-Authored-By: jbdoumenjou <jb.doumenjou@gmail.com>
mmatur and others added 8 commits February 21, 2019 21:56
@mmatur @jbdoumenjou @traefiker
Update provider/kubernetes/namespace.go
950f8b9 
Co-Authored-By: jbdoumenjou <jb.doumenjou@gmail.com>
@mmatur @jbdoumenjou @traefiker
Update provider/kubernetes/namespace.go
6f3b669 
Co-Authored-By: jbdoumenjou <jb.doumenjou@gmail.com>
@mmatur @jbdoumenjou @traefiker
Update provider/kubernetes/client.go
7f480a6 
Co-Authored-By: jbdoumenjou <jb.doumenjou@gmail.com>
@mmatur @jbdoumenjou @traefiker
Update provider/kubernetes/kubernetes.go
bbadc10 
Co-Authored-By: jbdoumenjou <jb.doumenjou@gmail.com>
@mmatur @jbdoumenjou @traefiker
Update provider/kubernetes/kubernetes.go
9f3664a 
Co-Authored-By: jbdoumenjou <jb.doumenjou@gmail.com>
@jbdoumenjou @traefiker
Fix for review
324412c
@ldez @jbdoumenjou @traefiker
Apply suggestions from code review
8ecbb58 
Co-Authored-By: jbdoumenjou <jb.doumenjou@gmail.com>
@jbdoumenjou @traefiker
Fix for review
813b77c
@traefiker traefiker merged commit 848e45c into traefik:master Feb 21, 2019
@jbdoumenjou jbdoumenjou deleted the feature/k8s branch February 22, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/ingress kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jbdoumenjou @mmatur @ldez @dtomcej @traefiker