Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates of Lego. #4480

Merged
merged 2 commits into from Feb 11, 2019
Merged

Updates of Lego. #4480

merged 2 commits into from Feb 11, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 9, 2019

What does this PR do?

Updates of Lego.

Motivation

Fixes:

  • Uses a jittered exponential backoff
  • httpreq: Endpoint with path.
  • fastdns: Do not overwrite existing TXT records
  • Log wildcard domain correctly in validation

Extra:

  • Add support for Openstack Designate as a DNS provider
  • gcloud: Option to specify gcloud service account json by env as string
  • [experimental feature] Resolve CNAME when creating dns-01 challenge. To enable: set LEGO_EXPERIMENTAL_CNAME_SUPPORT to true.

More

- [ ] Added/updated tests

  • Added/updated documentation

@ldez ldez added status/2-needs-review area/acme kind/bug/fix a bug fix bot/light-review decreases the number of required LGTM from 3 to 1. labels Feb 9, 2019
@ldez ldez added this to the 1.7 milestone Feb 9, 2019
mmatur
mmatur approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 2eb6516 into traefik:v1.7 Feb 11, 2019
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Feb 11, 2019
@ldez ldez deleted the fix/update-lego branch February 11, 2019 10:29
This was referenced Feb 13, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/M
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ldez @mmatur @traefiker