Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder Auth and TLSClientHeaders middleware #4557

Merged
merged 4 commits into from Mar 27, 2019

Conversation

tomberek
Copy link

@tomberek tomberek commented Mar 5, 2019

What does this PR do?

This provides ForwardAuth the chance to inspect and make decisions based
on the TLS information.

Motivation

Trying to write a ForwardAuth that uses TLS information to make nuanced access decisions.

More

  • Added/updated tests
  • Added/updated documentation

This provides ForwardAuth the chance to inspect and make decisions based
on the TLS information.
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants