Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove everything templates related #4595

Merged
merged 2 commits into from Mar 14, 2019
Merged

Remove everything templates related #4595

merged 2 commits into from Mar 14, 2019

Conversation

mpl
Copy link
Collaborator

@mpl mpl commented Mar 14, 2019

Also remove examples and contrib directories.

What does this PR do?

It removes the templates, examples, and contrib directories.
It also removes or disables the parts relying on the templates, and it removes the parts that were generating the templates.

Motivation

These directories are supposed to be deprecated and should not be used anymore.

More

I had to disable (with build tags) some of the unit tests of the old providers.

@ldez ldez added this to the next milestone Mar 14, 2019
@ldez ldez removed request for a team March 14, 2019 14:37
@ldez ldez changed the title all: remove everything templates related Remove everything templates related Mar 14, 2019
@dtomcej
Copy link
Contributor

dtomcej commented Mar 14, 2019

Screen Shot 2019-03-14 at 9 39 41 AM

Oh ya baby!
:shipit:

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpl and others added 2 commits March 14, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants