Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: kubernetes CRD provider #4620

Merged
merged 4 commits into from Mar 19, 2019
Merged

doc: kubernetes CRD provider #4620

merged 4 commits into from Mar 19, 2019

Conversation

mpl
Copy link
Collaborator

@mpl mpl commented Mar 18, 2019

What does this PR do?

This PR documents the kubernetes provider with Custom Resource Definition.

Motivation

Because docs were non-existent, and hence needed.

More

- [ ] Added/updated tests

  • Added/updated documentation

Additional Notes

Co-authored-by: Jean-Baptiste Doumenjou jb.doumenjou@gmail.com

@ldez ldez added this to the 2.0 milestone Mar 18, 2019
dtomcej
dtomcej suggested changes Mar 18, 2019
View reviewed changes
docs/content/middlewares/addprefix.md Outdated Show resolved Hide resolved
docs/content/middlewares/addprefix.md Outdated Show resolved Hide resolved
@mpl mpl changed the base branch from master to v2.0 March 18, 2019 16:53
dtomcej
dtomcej approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@ldez ldez self-requested a review March 18, 2019 18:32
@tlvenn

This comment has been minimized.

Sign in to view
@ldez
Copy link
Member

ldez commented Mar 19, 2019

Hi @tlvenn, Traefik has 2 modes in v2:

  • ingress strict (only ingress spec without annotations support)
  • CRD - IngressRoute (the subject of this PR), in this case you don't need annotations (and they are not supported) because the spec allow to define all options 🎉 .

For more information, join us on Slack https://slack.traefik.io

ldez
ldez approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit c4b7e8f into traefik:v2.0 Mar 19, 2019
@mpl mpl deleted the crdoc branch May 17, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/crd area/provider/k8s size/L
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mpl @tlvenn @ldez @jbdoumenjou @dtomcej @traefiker