Fix log messages about label selector #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
changed the title
ldez
added
status/2-needs-review
area/provider/k8s/crd
and removed
status/0-needs-triage
labels
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the kubernetes CRD provider, this PR changes the ingressLabelSelector var name into labelSelector, and it removes references to the word "ingress" in the related log messages.
Motivation
This is the kubernetes CRD code, so it has nothing to do with the Kubernetes Ingress, which is why references to Ingress should be removed.
More
- [ ] Added/updated tests- [ ] Added/updated documentation