Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rancher provider #4647

Merged
merged 11 commits into from Apr 5, 2019
Merged

Add Rancher provider #4647

merged 11 commits into from Apr 5, 2019

Conversation

SantoDE
Copy link
Collaborator

@SantoDE SantoDE commented Mar 21, 2019

What does this PR do?

Adds the rancher provider again

Motivation

Have rancher following the new provider system

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Have fun @ldez , @juliens and others :-D

@ldez ldez changed the title Add rancher again Add Rancher provider again Mar 21, 2019
@ldez ldez added this to the 2.0 milestone Mar 21, 2019
@SantoDE SantoDE changed the base branch from master to v2.0 March 21, 2019 14:21
@ldez ldez added this to In review in v2 Mar 21, 2019
@juliens
Copy link
Member

juliens commented Mar 27, 2019

Do you think you can add the TCP part? ( you can take a look at #4621 )

@SantoDE
Copy link
Collaborator Author

SantoDE commented Mar 27, 2019

Sure, I just wanted to have in a seperate PR (and when I did this, TCP was not implemented elsewhere :P)

@SantoDE SantoDE force-pushed the add_rancher_again branch 3 times, most recently from 67efe71 to a70ce4e Compare March 29, 2019 13:07
@SantoDE
Copy link
Collaborator Author

SantoDE commented Mar 29, 2019

ping @ldez , @juliens :) tcp support added and squashed

@ldez ldez force-pushed the add_rancher_again branch 3 times, most recently from 288e9a0 to 80bc7cb Compare April 2, 2019 15:42
@SantoDE SantoDE requested a review from a team as a code owner April 2, 2019 15:42
ldez
ldez approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit e1d097e into traefik:v2.0 Apr 5, 2019
v2 automation moved this from To review to Done Apr 5, 2019
@ldez ldez changed the title Add Rancher provider again Add Rancher provider Apr 12, 2019
@ldez ldez removed the request for review from a team April 12, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/provider/rancher kind/enhancement a new or improved feature. size/L
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SantoDE @juliens @jbdoumenjou @ldez @traefiker