Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old links in readme #4651

Merged
merged 2 commits into from Mar 22, 2019
Merged

Remove old links in readme #4651

merged 2 commits into from Mar 22, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 21, 2019

What does this PR do?

Remove old links in readme

Motivation

Fixes #4641

More

  • Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 2.0 milestone Mar 21, 2019
dduportal
dduportal approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but why is there a test code update?)

SantoDE
SantoDE approved these changes Mar 22, 2019
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do you really need commit 54565b5 included? :D

@ldez ldez added this to In review in v2 Mar 22, 2019
jbdoumenjou
jbdoumenjou approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 2e085fa into traefik:v2.0 Mar 22, 2019
@traefiker traefiker mentioned this pull request Mar 22, 2019
Closed
@ldez ldez moved this from In review to Done in v2 Mar 23, 2019
@ldez ldez deleted the fix/readme branch March 25, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@SantoDE SantoDE SantoDE approved these changes

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
area/documentation kind/bug/fix a bug fix kind/enhancement a new or improved feature. size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @jbdoumenjou @SantoDE @dduportal @traefiker