Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update traefik.sample.toml #4657

Merged
merged 1 commit into from Mar 25, 2019
Merged

Update traefik.sample.toml #4657

merged 1 commit into from Mar 25, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 23, 2019

What does this PR do?

Update traefik.sample.toml

Motivation

Have a valid configuration sample.

More

  • Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 2.0 milestone Mar 23, 2019
@ldez ldez added this to In review in v2 via automation Mar 25, 2019
nmengin
nmengin approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit a0e2f47 into traefik:v2.0 Mar 25, 2019
v2 automation moved this from To review to Done Mar 25, 2019
@ldez ldez deleted the fix/sample branch March 25, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@nmengin nmengin nmengin approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation kind/enhancement a new or improved feature. size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @jbdoumenjou @nmengin @dtomcej @traefiker