Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two minor nits in Traefik 2.0 docs #4692

Merged
merged 2 commits into from Mar 29, 2019
Merged

Fix two minor nits in Traefik 2.0 docs #4692

merged 2 commits into from Mar 29, 2019

Conversation

cfra
Copy link
Contributor

@cfra cfra commented Mar 29, 2019

What does this PR do?

It fixes two small issues found in the Traefik 2.0 documentation.

Motivation

I just upgraded to Traefik 2.0 and was confused how to configure routing rules. I think this is because the provided label in the documentation is incorrect in one location.

@ldez ldez changed the base branch from master to v2.0 March 29, 2019 12:03
@ldez ldez added this to the 2.0 milestone Mar 29, 2019
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch!

Thanks a lot 👼

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants