Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set X-Forwarded-* headers #4707

Merged
merged 3 commits into from Apr 2, 2019
Merged

Set X-Forwarded-* headers #4707

merged 3 commits into from Apr 2, 2019

Conversation

mpl
Copy link
Collaborator

@mpl mpl commented Apr 1, 2019

What does this PR do?

This PR adds the X-Forwarded headers to the proxied request.

Motivation

Fixes #4659

More

  • Added/updated tests
    - [ ] Added/updated documentation

Additional Notes

Co-authored-by: Julien Salleyron julien.salleyron@gmail.com

@traefiker traefiker added this to the 2.0 milestone Apr 1, 2019
juliens
juliens approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit 336135c into traefik:v2.0 Apr 2, 2019
@traefiker traefiker mentioned this pull request Apr 2, 2019
Closed
@mpl mpl deleted the xforward branch May 17, 2019 08:17
@snyk-bot snyk-bot mentioned this pull request Oct 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/middleware kind/bug/fix a bug fix size/L
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mpl @juliens @jbdoumenjou @dtomcej @dduportal @traefiker