Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds middlewares examples for k8s. #4713

Merged
merged 2 commits into from Apr 3, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Apr 3, 2019

What does this PR do?

Add k8s middlewares examples.

Motivation

Have a good documentation.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez changed the title Add k8s middlewares examples. Adds middlewares examples for k8s. Apr 3, 2019
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈 Looks Great To Me 🎈

@ldez ldez added this to To review in v2 via automation Apr 3, 2019
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 07d0eb9 into traefik:v2.0 Apr 3, 2019
v2 automation moved this from To review to Done Apr 3, 2019
@ldez ldez deleted the feature/doc-middleware branch April 3, 2019 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants