Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insensitive case for allow-empty value. #4745

Merged
merged 1 commit into from Apr 9, 2019
Merged

Insensitive case for allow-empty value. #4745

merged 1 commit into from Apr 9, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Apr 7, 2019

What does this PR do?

Insentive case for allow-empty value.

Motivation

Fix #4741

More

  • Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 2.0 milestone Apr 7, 2019
@ldez ldez added this to To review in v2 via automation Apr 7, 2019
juliens
juliens approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the title Insentive case for allow-empty value. Insensitive case for allow-empty value. Apr 8, 2019
geraldcroes
geraldcroes approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈 LGTM 🎈

@traefiker traefiker merged commit ee0e014 into traefik:v2.0 Apr 9, 2019
v2 automation moved this from To review to Done Apr 9, 2019
@traefiker traefiker mentioned this pull request Apr 9, 2019
Closed
2 tasks
@ldez ldez deleted the fix/allow-empty-label branch April 9, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@geraldcroes geraldcroes geraldcroes approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

Assignees
No one assigned
Labels
area/provider/docker kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @geraldcroes @jbdoumenjou @traefiker