Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation Update: Hosting.de wildcard support tested #4747

Merged
merged 1 commit into from Apr 9, 2019
Merged

Documentation Update: Hosting.de wildcard support tested #4747

merged 1 commit into from Apr 9, 2019

Conversation

martinhoefling
Copy link
Contributor

Works with Traefik 1.7.10 (lego release 2.4.0)

@martinhoefling @ldez
Hosting.de Wildcard Support tested
aabff97 
Works with Traefik 1.7.10 (lego release 2.4.0)
@martinhoefling martinhoefling requested review from a team as code owners April 8, 2019 15:03
@ldez ldez changed the base branch from master to v1.7 April 8, 2019 15:03
@ldez ldez removed request for a team April 8, 2019 15:03
@ldez ldez added this to the 1.7 milestone Apr 8, 2019
ldez
ldez approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez removed the bot/no-merge label Apr 9, 2019
geraldcroes
geraldcroes approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈 LGTM 🎈

dduportal
dduportal approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks !

@traefiker traefiker merged commit edd8e36 into traefik:v1.7 Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geraldcroes geraldcroes geraldcroes approved these changes

@dduportal dduportal dduportal approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/acme area/documentation kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@martinhoefling @geraldcroes @dduportal @ldez @traefiker