Add support proxyprotocol v2 #4755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/server
kind/enhancement
ldez
added
status/2-needs-review
contributor/waiting-for-corrections
and removed
status/1-needs-design-review
labels
c0va23
force-pushed
the
feature/proxyprotocol-v2
branch
from
e7f1a54
to
ff39eb3
Compare
|
I updated the package after reviewing and typos. Added more documentation on how to enable proxyprotocol. And made a rebase on the fresh code in the 2.0 branches. |
c0va23
force-pushed
the
feature/proxyprotocol-v2
branch
from
1ab0555
to
7c01cf2
Compare
|
Any chance this PR will be merged? |
ldez
force-pushed
the
feature/proxyprotocol-v2
branch
from
7c01cf2
to
4060660
Compare
traefiker
force-pushed
the
feature/proxyprotocol-v2
branch
from
8e9b166
to
ebbc7a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for proxyprotocol v2 headers.
The package provides support for proxy protocol v1 (https://github.com/armon/go-proxyproto) is replaced by the package (https://github.com/c0va23/go-proxyprotocol) supporting the analysis of both proxy protocol versions at the same time.
Motivation
Support for proxy protocol v2 need that traefik can be run using AWS NLB.
More
Additional Notes
Package github.com/c0va23/go-proxyprotocol tested manually with HA Proxy (v1 and v2) and on production with AWS NLB.
It PR #4561 migrated on branch v2.0