Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s static configuration explanation #4767

Merged
merged 3 commits into from Apr 17, 2019
Merged

k8s static configuration explanation #4767

merged 3 commits into from Apr 17, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Apr 13, 2019

What does this PR do?

k8s static configuration explanation.

Motivation

Have a good documentation.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to the 2.0 milestone Apr 13, 2019
@ldez ldez removed the area/acme label Apr 13, 2019
@ldez ldez added this to To review in v2 via automation Apr 13, 2019
jbdoumenjou
jbdoumenjou approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

mmatur
mmatur requested changes Apr 15, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small question

docs/content/providers/kubernetes-crd.md Outdated Show resolved Hide resolved
juliens
juliens previously requested changes Apr 16, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/content/providers/kubernetes-crd.md Outdated Show resolved Hide resolved
@ldez ldez dismissed juliens’s stale review April 17, 2019 09:39

the change has been added

@traefiker traefiker merged commit 62c03b3 into traefik:v2.0 Apr 17, 2019
v2 automation moved this from To review to Done Apr 17, 2019
@ldez ldez deleted the feature/doc-k8S-static branch April 17, 2019 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@mmatur mmatur mmatur approved these changes

@dtomcej dtomcej dtomcej approved these changes

@juliens juliens juliens left review comments

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/crd area/provider/k8s kind/enhancement a new or improved feature. size/M
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ldez @juliens @jbdoumenjou @mmatur @dtomcej @traefiker