Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dumpcerts.sh #4783

Merged
merged 1 commit into from Apr 17, 2019
Merged

Remove dumpcerts.sh #4783

merged 1 commit into from Apr 17, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Apr 16, 2019

What does this PR do?

Remove dumpcerts.sh

Motivation

The script have some issues, and we don't want to maintain this script, as replacement you can use:

More

  • Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 2.0 milestone Apr 16, 2019
This was referenced Apr 16, 2019
Closed
Closed
jbdoumenjou
jbdoumenjou approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the feature/remove-dumpcerts-script branch from 3ae8dfd to 13f09e6 Compare April 17, 2019 09:11
geraldcroes
geraldcroes approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 65679af into traefik:v2.0 Apr 17, 2019
@ldez ldez deleted the feature/remove-dumpcerts-script branch April 17, 2019 09:38
This was referenced Apr 20, 2019
Closed
Open
@ldez ldez mentioned this pull request Jul 16, 2019
Closed
1 task
@ldez ldez mentioned this pull request Aug 28, 2019
Closed
1 task
@ServError ServError mentioned this pull request Mar 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geraldcroes geraldcroes geraldcroes approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/documentation kind/enhancement a new or improved feature. size/M
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @geraldcroes @jbdoumenjou @mmatur @traefiker