Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review documentation #4798

Merged
merged 2 commits into from Apr 24, 2019
Merged

Review documentation #4798

merged 2 commits into from Apr 24, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Apr 19, 2019

What does this PR do?

  • adds missing Marathon examples
  • clean File provider section's titles
  • fixes tracing and loglevel
  • adds Rancher to the static configuration reference

Motivation

Have a good documentation.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Apr 19, 2019
@traefiker traefiker added this to the 2.0 milestone Apr 19, 2019
dduportal
dduportal approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

(Thanks for the txt syntax for blocks)

dduportal
dduportal suggested changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I gave my LGTM too quickly: the CI has 2 broken links due to titles

docs/content/providers/file.md Show resolved Hide resolved
docs/content/providers/file.md Show resolved Hide resolved
dduportal
dduportal approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

juliens
juliens approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 📚

@traefiker traefiker merged commit d807008 into traefik:v2.0 Apr 24, 2019
v2 automation moved this from To review to Done Apr 24, 2019
@ldez ldez deleted the feature/doc-review branch April 24, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@dduportal dduportal dduportal approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/documentation area/middleware kind/enhancement a new or improved feature. size/M
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @dduportal @nmengin @traefiker