Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compress link fixed #4817

Merged
merged 1 commit into from Apr 25, 2019
Merged

compress link fixed #4817

merged 1 commit into from Apr 25, 2019

Conversation

gato
Copy link
Contributor

@gato gato commented Apr 25, 2019

What does this PR do?

Compress link was pointing to circuit breaker doc

Motivation

"Don’t Live with Broken Windows" (The Pragmatic Programmer)

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@traefiker traefiker added this to the 2.0 milestone Apr 25, 2019
juliens
juliens approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dduportal
dduportal approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

jbdoumenjou
jbdoumenjou approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit b8b0c8f into traefik:v2.0 Apr 25, 2019
@gato gato deleted the patch-1 branch April 25, 2019 17:06
@ldez ldez added the kind/bug/fix a bug fix label Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
area/documentation area/middleware kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gato @juliens @jbdoumenjou @dduportal @ldez @traefiker