Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Rancher documentation. #4818

Merged
merged 1 commit into from Apr 26, 2019
Merged

fix: Rancher documentation. #4818

merged 1 commit into from Apr 26, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Apr 25, 2019

What does this PR do?

  • fix reference configuration
  • fix defaultRule doc.

Motivation

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez requested a review from SantoDE April 25, 2019 15:02
@traefiker traefiker added this to the 2.0 milestone Apr 25, 2019
@ldez ldez force-pushed the fix/rancher-doc branch 2 times, most recently from 4297675 to 2918b62 Compare April 25, 2019 17:26
@ldez ldez added this to To review in v2 via automation Apr 25, 2019
jbdoumenjou
jbdoumenjou approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SantoDE
SantoDE approved these changes Apr 26, 2019
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

@traefiker traefiker merged commit 0f2b774 into traefik:v2.0 Apr 26, 2019
v2 automation moved this from To review to Done Apr 26, 2019
@ldez ldez deleted the fix/rancher-doc branch April 26, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@SantoDE SantoDE SantoDE approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/rancher kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @jbdoumenjou @SantoDE @mmatur @traefiker