New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow SANs for wildcards domain. #4821
Conversation
80b3ef1
to
8b33549
Compare
Hi @vizv, Thanks for your interest in the project. Could you please rebase your PR on branch |
@mmatur I didn't test it on However it should work with v1.7, do you still want me to rebase |
yes could you rebase on v1.7, thanks |
8b33549
to
9e7eb95
Compare
updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e9760d4
to
ae8e32c
Compare
What does this PR do?
Allow issue certificates with multiple wildcard domains.
Motivation
More
Additional Notes
ACME specification actually allows multiple wildcard domains, it only says one wildcard (the * character) per domain, not one wildcard domain per certificate