Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SANs for wildcards domain. #4821

Merged
merged 3 commits into from May 3, 2019
Merged

Conversation

vizv
Copy link
Contributor

@vizv vizv commented Apr 25, 2019

What does this PR do?

Allow issue certificates with multiple wildcard domains.

Motivation

More

  • Added/updated tests
  • Added/updated documentation (will do)

Additional Notes

ACME specification actually allows multiple wildcard domains, it only says one wildcard (the * character) per domain, not one wildcard domain per certificate

@mmatur
Copy link
Member

mmatur commented Apr 26, 2019

Hi @vizv,

Thanks for your interest in the project.

Could you please rebase your PR on branch v1.7

@ldez ldez added this to the 1.7 milestone Apr 26, 2019
@vizv
Copy link
Contributor Author

vizv commented Apr 26, 2019

@mmatur I didn't test it on v1.7 I'm using v2.0.0-alpha4 right now, and with patched build here: https://cloud.docker.com/repository/registry-1.docker.io/vizv/traefik

However it should work with v1.7, do you still want me to rebase v1.7?

@ldez
Copy link
Member

ldez commented Apr 26, 2019

yes could you rebase on v1.7, thanks

@vizv vizv requested review from a team as code owners April 26, 2019 17:49
@vizv vizv changed the base branch from master to v1.7 April 26, 2019 17:50
@vizv
Copy link
Contributor Author

vizv commented Apr 26, 2019

updated

@ldez ldez removed request for a team April 26, 2019 22:03
@ldez ldez removed the bot/no-merge label Apr 26, 2019
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@ldez ldez merged commit cc130fb into traefik:v1.7 May 3, 2019
@vizv vizv deleted the wildcard-san-support branch May 13, 2019 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants