Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in routing example. #4849

Merged
merged 1 commit into from May 6, 2019
Merged

fix: typo in routing example. #4849

merged 1 commit into from May 6, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented May 6, 2019

What does this PR do?

Use consistent router name.

Motivation

Have a good documentation.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to the 2.0 milestone May 6, 2019
@ldez ldez added this to To review in v2 via automation May 6, 2019
juliens
juliens approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit 6818921 into traefik:v2.0 May 6, 2019
v2 automation moved this from To review to Done May 6, 2019
@ldez ldez deleted the fix/doc-routing branch May 6, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@nmengin nmengin nmengin approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation area/tls kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @nmengin @dtomcej @traefiker