fix the documentation about middleware labels. #4888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/provider
and removed
area/provider/docker
area/provider/marathon
area/provider/rancher
labels
ldez
changed the title
dniel
reviewed
May 18, 2019
There was a problem hiding this comment.
Tested in my config and seems to work perfectly with updated labels.
https://github.com/dniel/traefik-forward-auth0/blob/traefik2.docs/example/traefik2/docker-compose.yml#L15-L22
dniel
approved these changes
May 18, 2019
There was a problem hiding this comment.
Tested and its working in my config. https://github.com/dniel/traefik-forward-auth0/blob/traefik2.docs/example/traefik2/docker-compose.yml#L15-L22
traefiker
added
bot/merge-retry-1
status/4-merge-in-progress
and removed
bot/merge-retry-1
labels
traefiker
force-pushed
the
fix/doc-middleware
branch
from
8936d37
to
796873c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix middleware labels.
Motivation
Have a good documentation.
More
Added/updated tests