Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing callback on close of hijacked connections #4900

Merged
merged 1 commit into from
May 23, 2019
Merged

Add missing callback on close of hijacked connections #4900

merged 1 commit into from
May 23, 2019

Conversation

ravilr
Copy link
Contributor

@ravilr ravilr commented May 23, 2019

What does this PR do?

Updates oxy dependency

Motivation

Fixes #4864

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@traefiker traefiker added this to the 1.7 milestone May 23, 2019
@ldez ldez added kind/bug/fix a bug fix status/2-needs-review area/server bot/light-review decreases the number of required LGTM from 3 to 1. and removed status/0-needs-triage labels May 23, 2019
@ldez ldez changed the title Update oxy dependency Add missing callback on close of hijacked connections May 23, 2019
ldez
ldez approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@traefiker traefiker merged commit 8f135fd into traefik:v1.7 May 23, 2019
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels May 23, 2019
@dtomcej dtomcej mentioned this pull request May 23, 2019
Closed
1 task
@ravilr ravilr deleted the fix_4864 branch August 9, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/server kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ravilr @ldez @traefiker