Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify that Rancher provider is for 1.x only #4923

Merged
merged 5 commits into from Jun 3, 2019
Merged

Specify that Rancher provider is for 1.x only #4923

merged 5 commits into from Jun 3, 2019

Conversation

bradjones1
Copy link
Contributor

@bradjones1 bradjones1 commented May 30, 2019 •
edited

What does this PR do?

Updates the Rancher documentation to specify it is specific to Rancher 1.x.

Motivation

Rancher 2.x is basically a super-duper reverse proxy and control plane for Kubernetes.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@bradjones1
Specify that this provider is for Rancher 1.x only
ab1ce17 
Rancher 2.x is basically a super-duper reverse proxy and control plane for Kubernetes.
@traefiker traefiker added this to the 2.0 milestone May 30, 2019
@bradjones1 bradjones1 changed the title Specify that this provider is for Rancher 1.x only Specify that Rancher provider is for 1.x only May 30, 2019
@dtomcej dtomcej requested a review from SantoDE May 30, 2019 18:31
@dduportal
Copy link
Contributor

Hi @bradjones1 , thanks for this contribution.

Could you fix the issues raised by the CI (Travis) related to your change please?

=== Checking HTML content...
- /app/site/providers/rancher/index.html
  *  internally linking to ../kubernetes-crd/index.md, which does not exist (line 1577)
     <a href="../kubernetes-crd/index.md">Kubernetes provider</a>

(you can reproduce it locally before pushing your change by following instructions from the page Contributing -> Documentation, with the target make -C ./docs/ docs-verify.

dduportal
dduportal suggested changes May 31, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few feedbacks about the change content. Thanks!

docs/content/providers/rancher.md Outdated Show resolved Hide resolved
docs/content/providers/rancher.md Outdated Show resolved Hide resolved
@bradjones1 @dduportal
Update docs/content/providers/rancher.md per suggestion
bcb14e6 
Co-Authored-By: Damien Duportal <damien.duportal@gmail.com>
ldez
ldez requested changes May 31, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

docs/content/providers/rancher.md Outdated Show resolved Hide resolved
docs/content/providers/rancher.md Outdated Show resolved Hide resolved
@ldez ldez added this to To review in v2 via automation May 31, 2019
bradjones1 and others added 2 commits May 31, 2019 11:55
@bradjones1 @ldez
Update docs/content/providers/rancher.md
1a84b1b 
Co-Authored-By: Ludovic Fernandez <ldez@users.noreply.github.com>
@bradjones1
Revert title to original
647a485
dduportal
dduportal approved these changes Jun 2, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

SantoDE
SantoDE approved these changes Jun 3, 2019
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

@dduportal dduportal requested a review from ldez June 3, 2019 15:27
dtomcej
dtomcej approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

ldez
ldez approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@traefiker traefiker merged commit b143101 into traefik:v2.0 Jun 3, 2019
v2 automation moved this from To review to Done Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantoDE SantoDE SantoDE approved these changes

@dduportal dduportal dduportal approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/rancher kind/enhancement a new or improved feature. size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bradjones1 @dduportal @SantoDE @ldez @dtomcej @traefiker