Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo in documentation on rate limiting #4939

Merged
merged 2 commits into from Jun 12, 2019

Conversation

ableuler
Copy link
Contributor

@ableuler ableuler commented Jun 6, 2019

What does this PR do?

Fix an error in the file provider example in the documentation on rate-limiting middleware.

Motivation

Save others some time ;)

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@ldez ldez changed the base branch from master to v2.0 June 6, 2019 23:27
@ldez ldez added this to the 2.0 milestone Jun 6, 2019
@ldez ldez added this to To review in v2 via automation Jun 6, 2019
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the title fix(docs): correct typo in documentation on rate limiting Correct typo in documentation on rate limiting Jun 7, 2019
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📖 👍

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 9a4b455 into traefik:v2.0 Jun 12, 2019
v2 automation moved this from To review to Done Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants