Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix middleware names for CRD. #4966

Merged
merged 1 commit into from Jun 18, 2019
Merged

doc: fix middleware names for CRD. #4966

merged 1 commit into from Jun 18, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Jun 17, 2019

What does this PR do?

Fixes middleware names for CRD.

Motivation

Have a good documentation.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Jun 17, 2019
@traefiker traefiker added this to the 2.0 milestone Jun 17, 2019
dduportal
dduportal approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

dtomcej
dtomcej approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

jbdoumenjou
jbdoumenjou approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit be888b5 into traefik:v2.0 Jun 18, 2019
v2 automation moved this from To review to Done Jun 18, 2019
@ldez ldez deleted the fix/doc-case branch June 18, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@dduportal dduportal dduportal approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation area/middleware area/provider/k8s/crd kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @jbdoumenjou @dduportal @dtomcej @traefiker