Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define TLS options on the Router configuration for Kubernetes #4973

Merged
merged 11 commits into from Jun 21, 2019
Merged

Define TLS options on the Router configuration for Kubernetes #4973

merged 11 commits into from Jun 21, 2019

Conversation

jbdoumenjou
Copy link
Member

@jbdoumenjou jbdoumenjou commented Jun 18, 2019 •
edited

What does this PR do?

Allow to define and use TLS options in Kubernetes with CRD.

Motivation

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: juliens julien@containo.us

@traefiker traefiker added this to the 2.0 milestone Jun 18, 2019
@jbdoumenjou jbdoumenjou added this to To review in v2 via automation Jun 18, 2019
@jbdoumenjou jbdoumenjou added area/tls kind/enhancement a new or improved feature. and removed area/middleware labels Jun 18, 2019
dtomcej
dtomcej approved these changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job.

LGTM
:shipit:

juliens
juliens approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpl
mpl requested changes Jun 21, 2019
View reviewed changes
pkg/provider/kubernetes/crd/client_mock_test.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/kubernetes.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/kubernetes.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/kubernetes.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/kubernetes.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/traefik/v1alpha1/ingressroute.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/traefik/v1alpha1/ingressroute.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/traefik/v1alpha1/ingressroutetcp.go Outdated Show resolved Hide resolved
pkg/provider/kubernetes/crd/traefik/v1alpha1/tlsoption.go Outdated Show resolved Hide resolved
pkg/server/aggregator.go Show resolved Hide resolved
mpl
mpl approved these changes Jun 21, 2019
View reviewed changes
Copy link
Collaborator

@mpl mpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 80b3557 into traefik:v2.0 Jun 21, 2019
v2 automation moved this from To review to Done Jun 21, 2019
@traefiker traefiker mentioned this pull request Jun 21, 2019
Closed
2 tasks
@jbdoumenjou jbdoumenjou deleted the feature/k8s-tlsoptions branch November 15, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mpl mpl mpl approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/crd area/provider/k8s area/tls kind/enhancement a new or improved feature. size/L
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jbdoumenjou @juliens @mpl @dtomcej @ldez @traefiker