Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return an error when help is called on a non existing command. #4977

Merged
merged 1 commit into from Jun 19, 2019
Merged

Return an error when help is called on a non existing command. #4977

merged 1 commit into from Jun 19, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Jun 19, 2019 •
edited

What does this PR do?

Display an error when help is called on a non existing command.

Motivation

Be able to pass override-cmd test

To validate the test, the following commands must return an error:

./traefik echo Hello world-$RANDOM-$RANDOM
./traefik traefik echo Hello world-$RANDOM-$RANDOM
./traefik echo --help
./traefik traefik echo --help

Related to #4970

Related to docker-library/official-images#6106 (comment)
Related to https://github.com/containous/traefik-library-image/blob/master/alpine/entrypoint.sh

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Jun 19, 2019
@traefiker traefiker added this to the 2.0 milestone Jun 19, 2019
@ldez ldez mentioned this pull request Jun 19, 2019
Merged
@ldez ldez force-pushed the fix/help-commands-not-found branch from 855465c to ea16f2b Compare June 19, 2019 00:29
mmatur
mmatur approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dduportal dduportal mentioned this pull request Jun 19, 2019
Merged
dduportal
dduportal approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mpl
mpl approved these changes Jun 19, 2019
View reviewed changes
Copy link
Collaborator

@mpl mpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit a34876d into traefik:v2.0 Jun 19, 2019
v2 automation moved this from To review to Done Jun 19, 2019
@ldez ldez deleted the fix/help-commands-not-found branch June 19, 2019 13:17
@ldez ldez changed the title Display an error when help is called on a non existing command. Return an error when help is called on a non existing command. Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpl mpl mpl approved these changes

@dduportal dduportal dduportal approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/cli kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @mpl @dduportal @mmatur @traefiker