Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve various parts of the documentation. #4996

Merged
merged 4 commits into from Jun 21, 2019
Merged

Improve various parts of the documentation. #4996

merged 4 commits into from Jun 21, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Jun 21, 2019 •
edited

What does this PR do?

Improve some parts of the documentation.

Fixes #4995

Motivation

Have a good documentation.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Jun 21, 2019
@traefiker traefiker added this to the 2.0 milestone Jun 21, 2019
SantoDE
SantoDE approved these changes Jun 21, 2019
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

jbdoumenjou
jbdoumenjou approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the title Enhance some parts of the documentation. Improve some parts of the documentation. Jun 21, 2019
mpl
mpl requested changes Jun 21, 2019
View reviewed changes
docs/content/observability/logs.md Outdated Show resolved Hide resolved
docs/content/observability/logs.md Outdated Show resolved Hide resolved
docs/content/observability/logs.md Outdated Show resolved Hide resolved
docs/content/observability/logs.md Outdated Show resolved Hide resolved
mpl
mpl approved these changes Jun 21, 2019
View reviewed changes
Copy link
Collaborator

@mpl mpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez and others added 4 commits June 21, 2019 08:48
@ldez @traefiker
doc: enhance some parts.
8631318
@ldez @traefiker
doc: log title.
e3a9c8d
@ldez @mpl @traefiker
Apply suggestions from code review
2c0ec57 
Co-Authored-By: mpl <mathieu.lonjaret@gmail.com>
@ldez @polarathene @traefiker
Apply suggestions from code review
29a4db8 
Co-Authored-By: Brennan Kinney <5098581+polarathene@users.noreply.github.com>
@traefiker traefiker merged commit 69a1817 into traefik:v2.0 Jun 21, 2019
v2 automation moved this from To review to Done Jun 21, 2019
@traefiker traefiker mentioned this pull request Jun 21, 2019
Closed
2 tasks
@ldez ldez deleted the fix/doc-minor branch June 21, 2019 08:57
@mpl mpl changed the title Improve some parts of the documentation. Improve various parts of the documentation. Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polarathene polarathene polarathene left review comments

@mpl mpl mpl approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@SantoDE SantoDE SantoDE approved these changes

Assignees
No one assigned
Labels
area/documentation kind/enhancement a new or improved feature. size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ldez @mpl @jbdoumenjou @SantoDE @polarathene @traefiker