Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remarks about Rancher 2 #4999

Merged
merged 1 commit into from Jun 21, 2019
Merged

Add remarks about Rancher 2 #4999

merged 1 commit into from Jun 21, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Jun 21, 2019

What does this PR do?

Add remarks about Rancher2.

Motivation

Have a good documentation.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez requested a review from a team as a code owner June 21, 2019 14:27
@traefiker traefiker added this to the 1.7 milestone Jun 21, 2019
@ldez ldez changed the title Add remarks about Rancher2. Add remarks about Rancher 2 Jun 21, 2019
@ldez ldez mentioned this pull request Jun 21, 2019
Closed
dtomcej
dtomcej approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

SantoDE
SantoDE approved these changes Jun 21, 2019
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :)

dduportal
dduportal approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 📖

@traefiker traefiker merged commit 468e4eb into traefik:v1.7 Jun 21, 2019
@ldez ldez deleted the feat/rancher2 branch June 21, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantoDE SantoDE SantoDE approved these changes

@dduportal dduportal dduportal approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/rancher kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @SantoDE @dduportal @dtomcej @traefiker