Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove X-Forwarded-(Uri, Method, Tls-Client-Cert and Tls-Client-Cert-Info) from untrusted IP #5012

Merged
merged 2 commits into from Jul 8, 2019
Merged

Remove X-Forwarded-(Uri, Method, Tls-Client-Cert and Tls-Client-Cert-Info) from untrusted IP #5012

merged 2 commits into from Jul 8, 2019

Conversation

stffabi
Copy link
Contributor

@stffabi stffabi commented Jun 25, 2019

What does this PR do?

The changes of the PR #4036 didn't make their way to v2.0

Motivation

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@traefiker traefiker added this to the 2.0 milestone Jun 25, 2019
@ldez ldez changed the title Add changes of #4036 to v2.0 Remove X-Forwarded-Uri and X-Forwarded-Method from untrusted IP Jun 25, 2019
@jbdoumenjou
Copy link
Member

jbdoumenjou commented Jul 1, 2019 •
edited

Hi @stffabi,

Could you please add the X-Forwarded-Tls-Client-Cert and X-Forwarded-Tls-Client-Cert-Info ?
It would be great! 😄

@stffabi stffabi changed the title Remove X-Forwarded-Uri and X-Forwarded-Method from untrusted IP Remove X-Forwarded-Uri, X-Forwarded-Method, X-Forwarded-Tls-Client-Cert and X-Forwarded-Tls-Client-Cert-Info from untrusted IP Jul 2, 2019
@stffabi stffabi changed the title Remove X-Forwarded-Uri, X-Forwarded-Method, X-Forwarded-Tls-Client-Cert and X-Forwarded-Tls-Client-Cert-Info from untrusted IP Remove X-Forwarded-(Uri, Method, Tls-Client-Cert and Tls-Client-Cert-Info) from untrusted IP Jul 2, 2019
@stffabi
Copy link
Contributor Author

stffabi commented Jul 2, 2019

I've added the commit to remove the passTLSClientCert Headers.

ldez
ldez approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

jbdoumenjou
jbdoumenjou approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks ! 😃

juliens
juliens approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit cc4258b into traefik:v2.0 Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/middleware kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stffabi @jbdoumenjou @juliens @ldez @traefiker