Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/crd-acme: specify required kubectl version #5015

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Conversation

mpl
Copy link
Collaborator

@mpl mpl commented Jun 25, 2019

What does this PR do?

This change specifies the required minimum kubectl version for the Acme with CRD guide.

Motivation

The guide fails with kubectl version < 0.11

More

  • [ ] Added/updated tests
  • Added/updated documentation

Additional Notes

Fixes #4279 (maybe?)

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement 👍 LGTM

Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM 👍

@mmatur mmatur added this to To review in v2 via automation Jun 25, 2019
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit e7e268b into traefik:v2.0 Jun 25, 2019
v2 automation moved this from To review to Done Jun 25, 2019
@mpl mpl deleted the doccrd branch September 18, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants