Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for multiport services on Global Backend Ingress #5021

Merged
merged 1 commit into from Jun 27, 2019
Merged

Check for multiport services on Global Backend Ingress #5021

merged 1 commit into from Jun 27, 2019

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Jun 25, 2019

What does this PR do?

This PR checks for port matches on multiport services. This check is present in the main ingress processing, but was absent for the global ingress processing.

Motivation

Fixes #5000

More

  • Added/updated tests
  • Added/updated documentation - None needed, intended behavior(bugfix)

@dtomcej dtomcej requested a review from a team as a code owner June 25, 2019 16:32
@traefiker traefiker added this to the 1.7 milestone Jun 25, 2019
@dtomcej dtomcej added the kind/bug/fix a bug fix label Jun 25, 2019
SantoDE
SantoDE approved these changes Jun 26, 2019
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

ldez
ldez approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 8027e8e into traefik:v1.7 Jun 27, 2019
@traefiker traefiker mentioned this pull request Jun 27, 2019
Closed
2 tasks
@27Bslash6 27Bslash6 mentioned this pull request Aug 16, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantoDE SantoDE SantoDE approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/provider/k8s kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtomcej @SantoDE @mmatur @ldez @traefiker