Ensure WaitGroup.Done() is always called #5026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsdelf
changed the title
jbdoumenjou
added
kind/enhancement
ldez
added
kind/bug/fix
mpl
reviewed
Jul 9, 2019
mpl
reviewed
Jul 10, 2019
ldez
force-pushed
the
feature/pool-wg-robustness
branch
from
b9c68a7
to
8f1c939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes
Pool.Stop()andPool.Cleanup()finish their jobs even after panicking goroutines encountered.Motivation
Though
safe.Poolsupports recoverable goroutine,Pool.Stop()andPool.Cleanup()does not working correctly with panicking goroutines due to an unreliableWaitGroupcounter usage.More
Additional Notes
A new method
Pool.AddGo()was added corresponding to existingPool.AddGoCtx()to make a compact unit test possible.